Make EA close all trades when balance is below 10%

[Fabien S]

Close all when achieves (10)% profits That's mean the EA will read the balance and set the TP target to close depending on the percentage from settings Same for loses, set close all trades on 10% loses on balance.

i have made this ea but it doesnt work
shared/C6qakVyLb

can someone spot my mistake? Maybe i have to put it in On trade?

[Fabien S]

[Fabien S]


How do i get -10% of balance

[Fabien S]

@fabien-s nop doesnt work this way
also doesnt seem to work

[Fabien S]

@fabien-s the equals doesnt work however >= works, very strange

[l'andorrà]

Could you please share the project itself? Screenshot are partially explanatory but more info is required to find the problem.

[Fabien S]

https://fxdreema.com/shared/aoAeID5Kb

thats the link, i have rtades open that i want all to be closed when 10% profit or 10% loss on balance. Right now i got it working with >= but not ==. I also wanted to make the adjust a input parameter but somehow when i put % it rejects it hmm

[Fabien S]

@fabien-s the problem with >= is that its not 10% but a bit more

[Fabien S]


I also wonder if this is the right way to do it..

[fxDreema]

No, no, no... don't add one of these "inp..." things in Constants. And don't use == when you compare prices or money. Use anything else, but not ==.

10%, but 10% of what? Balance is the amount of money you had the last time you had 0 opened orders. Close all opened orders and the Balance is equal to Equity now. Do you really want to compare Balance with Equity?

10% sounds to me like such a small value that you should not reach it so quickly. If Equity can be less than 10% of the Balance, this EA is not good from the start.

If you mean 10% from some initial value... for example you can deposit 1000 dollars and you want to close everything when you reach 100 dollars, even if this is 6 months in the future... then the problem is that the EA can't really know what is that initial value that you had in mind half a year ago. There are ways to remember values for a while, but in this case maybe it's better to hard code the value in the EA

Otherwise you can try something like this:

Remember that here Equity and Balance are those global values that are result from all trades.

Or this one:

Here this block calculates the profit from the running orders only, it doesn't care about closed orders. AccountBalance() gives you the balance. This is function from MQL4. There is also AccountEquity() and other functions.
So, let's say the we have initial deposit of 1000 dollars. This is the Balance. Then we start losing and the block calculates that out profit is negative. The block would pass if the profit is < 20, because -1 * 1000 * (0.02) is 20. I made my tests and it was easier for me to close the trades when the loss was below 98% of the balance, that's why I used 98 there.
Note that the values used there have .0 at the end. Apparently, if you do it like this (100 - 98 / 100), the calculation will fail, because in MQL4 these numbers are integers and the final result is also integer. The result can't be 0.02, it will be 0. To get the result as floating point number, I wrote these numbers as floating numbers.

[Fabien S]

@fxdreema Thanks a lot for your answer; I really appreciate the help