You can remove blocks 6 and 10. They are redundant. Other than that your logic is correct. It should work. Is this the whole project or just part of it?
Place a shared link to look at, the on trade tab will only place a trade when something happens, you likely are using a block that constantly passes when a trade is created.