Posts made by fxDreema

I feel this has something to do with having the project opened in more than one tab. This usually leads to such unexpected and catastrophic consequences for the project. Not the fact that the same project is opened multiple times, but when you start doing something on an older instance of the project, there would be discrepancies with the newer version that is in the database on the server.

At the moment there is no functionality to auto-detect when the same project is opened 2 or more times at the same time, so personal attention is required.

Don't work on the same project in 2 or more different tabs. It will be possible to work on different projects this way, but not on a single one. If you have one project opened in one tab, close the other tabs where it is also opened. Also, if you have a tab opened at a certain project hours ago, reload the page just to be sure.

I have to say this once again. If anyone suspects a bug, please, make a simple project with the minimum blocks required (should be no more than 4-5 blocks) to demonstrates the bug + short explanation of what is expected to happen.

Sorry, but I don't have this will to dissect projects with 100s of blocks, and even worse - containing many input properties, which will probably be way different on my end.

I ran your project in my tester for a period of 1 year and guess what - I got only 2 positions for the whole time. I don't know why, but I don't want to know why. I just want a simple example, that when I run it, it will fail.

Don't forget that if you (I mean everyone) understand your project, this doesn't mean that I understand it.

When there is a bug, I really want to fix it, but I don't want to explore anyone's projects, strategies and ideas, while searching for a bug that may not even appear on my side at all.

How to make such example?

• Download the project as .mq5 file, then import it back. A new project will be created. Maybe rename the new one. Still ensure that the original project is still there.
• Start deleting blocks. First delete those blocks who surely have nothing to do with the problem. At this point maybe half of the blocks should be gone.
• Continue deleting other blocks. While deleting blocks, test to see that the problem still remains. If the problem goes away, return one or more steps back (un-delete blocks).
• Repeat this until very few blocks remain, and the problem still remains. Leave only the Buy or the Sell side.
• If indicators are not necessary, delete them.
• Remove all input parameters (Constants), because they often lead to unnecessary confusions.
• Remove the Variables as well, unless they are needed for the problem to appear.
• The final example should look nothing like the original project. It should contain less than 10 blocks for sure.

It was just reported to me that there are compilation errors on the latest build of MT5 - build 3674. I tested it and it's true, if you try to compile (probably) any EA, generated by fxDreema in MetaEditor build 3674, you will get this error.

It's about Function templates. See the documentation here: https://www.mql5.com/en/docs/basis/oop/templates
So, even if you try the simplest example from the documentation, this error appears.

I think they introduced a bug in their latest compiler. This problem is also reported in their forum, see this: https://www.mql5.com/en/forum/445197

I also found this topic from yesterday (https://www.mql5.com/en/forum/445154), where another bug was reported in build 3672 that apparently has been fixed in build 3673. So I think the current "template" bug will be also fixed eventually.

In short, for now I'm not going to try to fix anything, because I believe that it's a MetaQuotes bug that will be fixed in some of the following builds. The compiler on the website is older version and there are no problems there.

I just tested it, and it seems that when you decide to close MetaTrader 4, just before it closes it calls the Deinit event on EAs. I just placed "Pass -> Play sound" in "on Deinit", closed my MetaTrader and I heard a sound.

However, when I tested "Pass -> Terminate" in "on Deinit", it didn't really worked. After I stared it again, the EA was still in the chart.

I also noticed that MetaTrader hanged for a while at the Terminate block, which is probably because it has additional ChartRedraw() function there, so I tested the native function ExpertRemove() in a "Custom MQL code" and this time it didn't hang, but still, after restart the EA was still in the chart. I don't really know how to remove EAs from the charts when you close MetaTrader.

Someone getting "Forbidden" error message when trying to submit a post?

Here is an example I just did: https://fxdreema.com/shared/wCVSsE1Ib

It creates a position, then after 1 hour it closes half of it, then after 1 more hour it closes it fully.

In "on Trade" I placed some blocks to see what is going on. I want to detect partial close, full close, and a close in general (partial of full), and for each of these I print a text on the chart.
Additionaly, in the logs I print some information with that Alert block.

I think this works correctly.

Your example is a little bit... it contains blocks that can be removed from there. But it's very possible that I fixed some wrong behavior. Yes, lately I was doing some changes and it looks that this changed the way your EA works. I wonder... did I broke something or did I fixed something. I don't fully understand the intention of your project, and that's why I can't tell what is the problem in it. But maybe you can get an idea from my project.

@LALI It sounds fair. I added one extra rule to give bonuses to people like you, who had paid status after June 20.

The website was down today for 2 hours and 40 minutes. Hosting maintenance I guess, because it went down at exactly 12:00 UTC. At the moment there is still a notification about this issue at this page (look at London): https://status.vultr.com/

@roar I had parthership proposals from brokers, and not only brokers, but I always decline. I'm very anti-parthership for some reason, so much that I don't even want to hire someone to do something instead of me. But lately, and especially after the hack, I started to realize that I'm probably not enough for this project and my strong anti-parthership shell is starting to crack a little bit.
But brokers... I look at them as the enemy, although without them this website would not exist.

There is also this "Betting: Custom Sequence" option if the sequence of lots is too crazy.

Variables are easy, they just hold values. The most complicated thing about them is their types. But most of the time the type is int for whole numbers, double for floating numbers, string for text or bool for true/false. In MQL4 and MQL4 there are also bunch of enumerations, they are a little bit more complicated types, but their names start with ENUM_... and once you kinda understand how to use them, you can easily find them in MQL's documentation.

I confirm that there is a "bug" when after some of the "For each..." blocks a non-pink block is used. Like in the example in my previous post, where "Buy pending order" changes the values of "(in loop)...".

I tried to find if this is a new problem, but I think the problem is ancient, it has always been like this. I guess this explains why very often people are using pink blocks after buy/sell blocks without problems - those buy/sell blocks are acting like "For each...". So even if I find a way to fix this bug, maybe it will broke some people's projects. It looks to me like a bug, so old that it turned into a feature.

@roar said in When to stop OnInit():

Some event tabs have those specific filters, maybe the OnInit could have similar blocks too...

The problem with this is that if I want to add such blocks, I should remove this code and allow the whole OnInit() body to run always, which can change the behavior of the EAs for some people.

There are such problems everywhere in the EA builder where if I want to change or remove something, unexpected things could happen to many user's projects. And this is not like fixing a bug. If it's a bug, at least I can say "Yeah, but it worked wrong before and now I fixed it".

I think I should somehow make a whole new version of the EA builder, incompatible with this one, on a different link. Like 2.0 or something. Similar to how MT4 and MT5 exist in parallel. But I don't think I have enough breaking changes in mind to justify this.

I probably put this code there when someone was having issues when changing the parameters of the EA, or changing the timeframe. I don't remember exactly.

I think the only two possible uninitialize reasons in OnInit() are REASON_CHARTCHANGE or REASON_PARAMETERS, which means that the "else" statement is about REASON_PARAMETERS.

It looks that I wanted to prevent re-execution of blocks in "on Init" when the user changes the timeframe or the EA parameters. Only if the symbol is changed, the blocks would run again, which was probably because I have some symbol-related functions just below this code.

I guess it depends. Maybe the user wants to redraw his objects, maybe not.

Actually these REASON_CHARTCHANGE and REASON_PARAMETERS are forming possible events, something like "on Timeframe Change", or "on Parameters Change". Sometimes I'm thinking about adding some more events in the EA builder, or better changing the way events are used in the EA builder, maybe allowing for making custom events. But at the moment there are only these standard events and the use of REASON_CHARTCHANGE and REASON_PARAMETERS in on Init is opinionated.

By the way, I don't think this is a bug.

@roar Nice to see someone else asking for isolated examples

@l-andorrà Yesterday I was touching a little bit on the Trade events. Now minutes ago I touched that again. But I don't see how this is related to the variables.
I would also like some isolated project.

I rewrote some functions and I uploaded the changes. I did this for MQL4 and MQL5. What is different is the way events are detected, basically now the detection should work when there are multiple events happening at the same time.

Here is a project that I used to produce these events at the same time: https://fxdreema.com/shared/CKK1K7bQ What is different than your project is that initially I'm creating 2 positions and 2 pending orders. SL for both positions is the same and OpenPrice for both pending orders is the same. So all these 4 events would happen at the same time.

I used this sllevel variable, because I noticed anothe problem that I consider a bug. It's that if I use (in loop).... Stop-Loss in both Buy pending order blocks, the value that we get in the second block is wrong. I think Stop-Loss becomes the Stop-Loss of the pending order from the first Buy pending order block.

Here is a little trick that can help you see the data of the events. In the generated source code find debug = false; and change it to debug = true;. This will allow printing of some data in the logs, it's very nice.

I did one more change and I got a little bit more success, in particular when 2 positions and 1 pending order is created, but it doesn't work correctly when 2 positions and 2 pending orders are created. It seems that I have to rewrite the algorithm for detecting Trade events. This will probably take days.

I think I fixed the problem, and the good thing is that now I don't expect something else to break because of this. As I mentioned, I have this class to detect Trade events, and there was a place in this class where I just printed some message instead of trying to detect anything, it was kinda unfinished. But it was unfinished, because I didn't even expect to ever reach this place. Well, I guess in MQL5 every strange and unexpected situation is possible.

And the issue was that while the pending order is triggered at the same time when SL of the position is triggered, my Trade-detecting class detected this as a single event (instead of two), and not just any event, but one that it could not resolve.

Now I have to fix the situations when I try to open two pending orders at the same price, or to create two positions initially. These situations doesn't work.

@QuantEngineer Damn, you have so many custom blocks, you have like another EA builder.

@OntradingX said in Position Created block with failure.:

@fxDreema Please at least let us know if you are trying to resolve it. Being without answers is worse than not having the solution to the problems.

Yes, I started investigating this bug. It's a little bit strange situation and it will take some time, because the problem happens in a relatively large class that I wrote before for detecting Trade events, and I have to remind myself how all of this worked.

Otherwise the problem happens when the pending order and stop-loss of the position are very close to each other (they can be different). Group numbers doesn't matter.

I also have a message "Positions order mismatch", which basically means "I don't know what kind of event is this, something is off".

I'm not sure, but I think this bug is not related to my latest code changes, I think this one is an old bug that you just discovered.

This topic is old and if there was a problem, maybe I fixed it, I don't remember.

But I actually have this Market is closed problem when I'm trying to trade in the Init event, and this happens in the Tester, it works for me when Live. I don't know the reason fot that and I have not investigated it.

@Sparrow I just worked on a bug, reported in another topic (https://fxdreema.com/forum/topic/16239/for-each-closed-position-block-is-not-working), and the problem was exactly that Open Time for closed positions didn't work properly. I think this is fixed now. Sorry that it took few days, I worked on some JavaScript things these days.

I see you are interested in MQL5 a little bit, so I can tell you what was the problem. I have these custom MQL4-like function in MQL5, one of which is OrderOpenTime().

This function has some if in it, because it can work with positions, closed positions or pending orders. When it works with closed positions, there is a variable type that equals to 3, so we end up in ... else if (type == 3) .... The code there is like this:

ulong positionId = HistoryDealGetInteger(OrderTicket(), DEAL_POSITION_ID);

  HistorySelectByPosition(positionId); // <<< THIS WAS NOT HERE, I ADDED IT TODAY

  ulong ticket = HistoryDealGetTicket(0);
		
  time = (datetime)HistoryDealGetInteger(ticket, DEAL_TIME);
		
  HistoryTradesTotalReset();

Note my THIS WAS NOT HERE, I ADDED IT TODAY comment there, this is the code that was missing and causing the bug.

OrderTicket() would be the ticket of a deal, selected by "For each Closed Position", but this is a deal that is OUT, it's the final closing deal. We want the open time, and to get this information we want to get the first IN deal from this same position. To do this we need to get this DEAL_POSITION_ID number, then to use HistorySelectByPosition() and from there to get that first IN deal.
But some days ago, when worked to fix some other problems, I forgot to put HistorySelectByPosition() in this particular function, or I deleted it by mistake. There is one similar function OrderOpenPrice() and there I had HistorySelectByPosition(). I knew that both functions are the same when it comes to loading these deals, and these few rows of code should be exactly the same in both functions, but somehow this one row of code went missing in OrderOpenPrice().